Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/vm naming #1311

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Fix/vm naming #1311

merged 2 commits into from
Jul 14, 2022

Conversation

jdknives
Copy link
Member

Did you run make format && make check?

Fixes https://github.com/SkycoinPro/skywire-services/issues/573

Changes:

  • prepend service name to metrics name

@jdknives
Fix Victoria metrics naming
7194454 
Prepend service name to metrics name.
@jdknives jdknives changed the base branch from master to develop July 14, 2022 12:01
@jdknives
Fix request duration by status code
1f33b77 
Previously the request duration by status code query was incorrect.
@jdknives jdknives merged commit 2dfe1ab into skycoin:develop Jul 14, 2022
@jdknives jdknives deleted the fix/vm-naming branch July 14, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrpalide mrpalide mrpalide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdknives @mrpalide